Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for custom_log_collection #861

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Add configuration for custom_log_collection #861

merged 2 commits into from
Oct 6, 2022
+20 −0

Conversation

nilskuehme
Copy link
Contributor

Achieved:

This Pull Request allow it to create a config file for the custom_log_collection DataDog integration.

It works the same as adding a log file configuration for an integration using that community cookbook and makes it possible to use the custom_log_integration as follows:

node.default['datadog']['custom_log_collection']['logs'] = [
  {
    'type' => 'file',
    'path' => '</path/to/logfile>',
    'source' => '<source>',
    'tags' => [
      'tag1:value1',
      'tag2:value2'
    ]
  }
]

@nilskuehme nilskuehme requested a review from a team as a code owner September 23, 2022 11:48
@nilskuehme
Copy link
Contributor Author

nilskuehme commented Sep 27, 2022 •
edited
Loading

Hi @martinisoft , are there any updates? 😃

@martinisoft
Copy link
Contributor

Hi @martinisoft , are there any updates? 😃

I won't be the one chiming in here as I haven't contributed to this repository for some time now. Hopefully someone from Datadog will notice this.

@amenasria
Copy link
Member

👋 Hey @nilskuehme, sorry for the late reply. Thanks a lot for your PR !

Lot of work right now, our team will review it in the following weeks.

@nilskuehme
Copy link
Contributor Author

Hi @martinisoft , are there any updates? smiley

I won't be the one chiming in here as I haven't contributed to this repository for some time now. Hopefully someone from Datadog will notice this.

Okay, thank you and sorry for reaching you out.

@nilskuehme
Copy link
Contributor Author

Hi @amenasria, yeah I can understand that. Unfortunately we need all 3 changes in our production as soon as possible. Is there any way to take a look on it from you side earlier? That would help us a lot.

Thank you very much.

julien-lebot
julien-lebot approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@julien-lebot julien-lebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

KSerrania
KSerrania approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@KSerrania KSerrania merged commit aad84d8 into DataDog:main Oct 6, 2022
@nilskuehme nilskuehme deleted the Add-custom_log_collection-configuration branch October 7, 2022 08:34
@nilskuehme
Copy link
Contributor Author

Thank you very much guys 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lebot julien-lebot julien-lebot approved these changes

@KSerrania KSerrania KSerrania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nilskuehme @martinisoft @amenasria @julien-lebot @KSerrania